[microNPU] Enforce bias when pattern matching conv2d #9244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently a conv2d pattern is matched when no bias is present. However, legalization expects a bias to be present, therefore causing an error when this is not the case. For now, enforce a bias when offloading conv2d to the NPU. Change-Id: I7f74b0f2c151f51ddc66ee1c5ebb77534238909b
lhutton1
requested review from
anijain2305,
jroesch,
junrushao,
jwfromm,
MarisaKirisame,
mbrookhart,
slyubomirsky,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
Mousius
approved these changes
Oct 12, 2021
masahi
pushed a commit
to Laurawly/tvm-1
that referenced
this pull request
Oct 14, 2021
Currently a conv2d pattern is matched when no bias is present. However, legalization expects a bias to be present, therefore causing an error when this is not the case. For now, enforce a bias when offloading conv2d to the NPU. Change-Id: I7f74b0f2c151f51ddc66ee1c5ebb77534238909b
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
Currently a conv2d pattern is matched when no bias is present. However, legalization expects a bias to be present, therefore causing an error when this is not the case. For now, enforce a bias when offloading conv2d to the NPU. Change-Id: I7f74b0f2c151f51ddc66ee1c5ebb77534238909b
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Currently a conv2d pattern is matched when no bias is present. However, legalization expects a bias to be present, therefore causing an error when this is not the case. For now, enforce a bias when offloading conv2d to the NPU. Change-Id: I7f74b0f2c151f51ddc66ee1c5ebb77534238909b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a conv2d pattern is matched when no bias is present. However, legalization expects a bias to be present, therefore causing an error when this is not the case. For now, enforce a bias when offloading conv2d to the NPU.
cc @ekalda @mbaret @manupa-arm @dchauhan-arm